.direnv directory should not be packaged
#2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If somebody uses direnv tool, the `.direnv` directory is created, that contains some data and especially some symlinks. Symlinks makes `vsce` to fail zipping the built VSIX. Generally `.direnv` should not be added to the resulting VSIX, therefore I add it to .vscodeignore.
|
dosubot
bot
added
size:XS
mrubens
approved these changes
Apr 10, 2025
Collaborator
mrubens
left a comment
mrubens
left a comment
There was a problem hiding this comment.
Thank you!
I see your point, but I'm nervous about the whitelist approach leading to problems where something works locally but we forget to add to this file and the marketplace build doesn't work...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & Implementation
If somebody uses direnv tool, the
.direnvdirectory is created, that contains some data and especially some symlinks. Symlinks makesvsceto fail zipping the built VSIX.Generally
.direnvshould not be added to the resulting VSIX, therefore I add it to .vscodeignore.Maybe we should use "whitelist" strategy of defining what should be packaged instead of "blacklist"?
Screenshots
How to Test
Get in Touch
Discord handle: wkordalski
Important
Add
.direnv/**to.vscodeignoreto prevent packaging issues withvscedue to symlinks..direnv/**to.vscodeignoreto exclude.direnvdirectory from VSIX package.vscefailing due to symlinks in.direnv.This description was created by
for ac0ffee. It will automatically update as commits are pushed.